Fix libpcre2 bindings with arch-dependent types (SizeT)
#13088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
HertzDevil
approved these changes
Feb 18, 2023
straight-shoota
changed the title
libpcre2 bindings with arch-dependent types (SizeT)
straight-shoota
added a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib function
get_ovector_pointerreturnsLibC::SizeT, notUInt64. They happen to be identical on 64-bit architectures, but not on 32-bit. This fix uses the correct type inRegex::MatchData.I'm also pinning wasm32_test to use PCRE because the wasm libraries from https://github.com/lbguilherme/wasm-libs do not provide PCRE2 yet.