Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(perms):replace GHCR_PR_TOKEN with GITHUB_TOKEN #628

Closed
wants to merge 0 commits into from
Closed

ci(perms):replace GHCR_PR_TOKEN with GITHUB_TOKEN #628

wants to merge 0 commits into from

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Sep 15, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #613
Depends on: #619

Description of the change:

Since the event is pull_request_target, the GITHUB_TOKEN can be used to elevate its permission to write:packages. We can utilize this instead of the GHCR_PR_TOKEN PAT.

Motivation for the change:

Raised by Thuan

How to manually test:

  1. Insert steps here...
  2. ...

@aali309 aali309 requested a review from tthvo September 15, 2023 18:53
@tthvo
Copy link
Member

tthvo commented Sep 15, 2023 •
edited by aali309
Loading

I think we should hold off this PR until #619 is merged. A lot have changed there.

@aali309
Copy link
Contributor Author

aali309 commented Sep 15, 2023 •
edited
Loading

I think we should hold off this PR until #619 is merged. A lot have changed there.

ok.. so close it or just keep it till when its ready?

@tthvo
Copy link
Member

tthvo commented Sep 15, 2023 •
edited
Loading

Just keep it open here now and rebase later :)) You can add Depends on #619 in this PR body.

@aali309 aali309 changed the title feat(ci):replace GHCR_PR_TOKEN with GITHUB_TOKEN ci(perms):replace GHCR_PR_TOKEN with GITHUB_TOKEN Sep 15, 2023
@tthvo tthvo mentioned this pull request Sep 18, 2023
Merged
7 tasks
@tthvo
Copy link
Member

tthvo commented Sep 20, 2023

Hey @aali309, rebase pls. We should be unblocked now.

@aali309 aali309 closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo Awaiting requested review from tthvo

Assignees
No one assigned
Labels
ci safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Replace GHCR_PR_TOKEN with GITHUB_TOKEN
2 participants
@aali309 @tthvo