Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): PR command build_test #619

Merged
merged 3 commits into from
Sep 20, 2023
Merged

chore(ci): PR command build_test #619

merged 3 commits into from
Sep 20, 2023

Conversation

mwangggg
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #618

@mwangggg mwangggg added feat New feature or request ci safe-to-test chore Refactor, rename, cleanup, etc. and removed feat New feature or request labels Aug 30, 2023
@mwangggg mwangggg changed the title feat(ci): PR command build_test chore(ci): PR command build_test Aug 30, 2023
@mwangggg
Copy link
Member Author

demo: mwangggg#1

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
andrewazores
andrewazores previously approved these changes Aug 31, 2023
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any other feedback @tthvo ?

andrewazores
andrewazores previously approved these changes Aug 31, 2023
@andrewazores
Copy link
Member

LGTM but since @ebaron does more of the maintainer work here, I think he should at least take a look over the changes.

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mwangggg, very sorry for taking so long to get to this. Looks great overall, I just have a couple questions below. I really like splitting the workflows into separate PR and push files. This should improve security as well since the Quay.io secret isn't available with pull_request_target events anymore.

.github/workflows/build-ci.yml Outdated Show resolved Hide resolved
.github/workflows/test-ci.yaml Outdated Show resolved Hide resolved
@mwangggg
Copy link
Member Author

demo: mwangggg#2

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! @tthvo any other comments?

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! Nice job @mwangggg! Thankss!

@ebaron ebaron merged commit 17d7420 into cryostatio:main Sep 20, 2023
15 checks passed
@ebaron
Copy link
Member

ebaron commented Sep 20, 2023

@mwangggg I noticed the CI is failing with the following warning when trying to push the test images to GHCR:
Warning: Username is provided, but password is missing

I think we need to add something like this when calling the reusable workflow:

    secrets:
       GHCR_PR_TOKEN: ${{ secrets.GHCR_PR_TOKEN }}

https://docs.github.com/en/actions/using-workflows/reusing-workflows#passing-secrets-to-nested-workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] PR command to run build + tests
4 participants