chore: Update Crossplane-tools version used and remove Get/Set methods on ProviderReferences#122
Closed
chaitanyakolluru wants to merge 2 commits into
Closed
Conversation
chaitanyakolluru
changed the title
Signed-off-by: Chaitanya Kolluru <chaitanya.r.kolluru@gmail.com>
Signed-off-by: Chaitanya Kolluru <chaitanya.r.kolluru@gmail.com>
chaitanyakolluru
force-pushed
the
update-tools
branch
from
1375aab to
6767c11
Compare
Collaborator
|
@chaitanyakolluru thank you for your PR. However, these changes are already included in #119. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This MR updates reference to crossplane-tools to accommodate recent changes to not generate get/set methods on providerRef and removes said methods in all the zz* files. Crossplane-tools MR here.
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Changes in the forked branch are applied against a Composition function and it doesn't generate errors based on Get/Set ProviderReference not having the reference under mg's spec.
[contribution process]: https://git.io/fj2m9