feat: Upgrade to crossplane-runtime v1.14.4#119
Merged
janwillies merged 1 commit intoFeb 21, 2024
Conversation
MisterMX
force-pushed
the
feat/crossplane-runtime-v1.14
branch
3 times, most recently
from
b4e52e1 to
ae5d898
Compare
2 tasks
somebadcode
reviewed
Feb 2, 2024
janwillies
requested changes
Feb 9, 2024
janwillies
left a comment
janwillies
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @MisterMX! Looks good to me, but before merging please run s/aws/gitlab/
MisterMX
force-pushed
the
feat/crossplane-runtime-v1.14
branch
2 times, most recently
from
5acc514 to
a19c46c
Compare
janwillies
requested changes
Feb 14, 2024
janwillies
left a comment
janwillies
left a comment
Collaborator
There was a problem hiding this comment.
Some of aws still present :)
|
|
||
| // Package v1alpha1 contains core AWS resources. | ||
| // +kubebuilder:object:generate=true | ||
| // +groupName=aws.crossplane.io |
Collaborator
There was a problem hiding this comment.
These should be gitlab and a couple others too
Closed
1 task
MisterMX
force-pushed
the
feat/crossplane-runtime-v1.14
branch
5 times, most recently
from
795f7c1 to
77ed6c1
Compare
Add support for store configs. Add support for management policies. Bump golanci-lint to v1.54.0 Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
feat/crossplane-runtime-v1.14
branch
from
77ed6c1 to
f065d04
Compare
janwillies
approved these changes
Feb 21, 2024
janwillies
left a comment
janwillies
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks @MisterMX!
| "${HELM3}" repo add crossplane-stable https://charts.crossplane.io/stable/ --force-update | ||
| chart_version="$("${HELM3}" search repo crossplane-stable/crossplane | awk 'FNR == 2 {print $2}')" | ||
| "${HELM3}" repo add crossplane-stable https://charts.crossplane.io/stable/ | ||
| chart_version="1.14.5" |
Collaborator
There was a problem hiding this comment.
I'm not a huge fan of hard coding the version. Why is it necessary?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support for store configs.
Add support for management policies.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
n.a. since no changes in the controller logic have been made. Only Setup has been adjusted.