Skip to content

Add multimodal embedding support#590

Open
Ndunge-Makau wants to merge 21 commits intocrmne:mainfrom
Ndunge-Makau:add-multimodal-embedding-support
Open

Add multimodal embedding support#590
Ndunge-Makau wants to merge 21 commits intocrmne:mainfrom
Ndunge-Makau:add-multimodal-embedding-support

Conversation

@Ndunge-Makau
Copy link

What this does

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Required for new features

  • I opened an issue before writing code and received maintainer approval
  • Linked issue: #529

PRs for new features or enhancements without a prior approved issue will be closed.

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
    • For provider changes: Re-recorded VCR cassettes with bundle exec rake vcr:record[provider_name]
    • All tests pass: bundle exec rspec
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

AI-generated code

  • I used AI tools to help write this code
  • I have reviewed and understand all generated code (required if above is checked)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

Copy link

@kaka-ruto kaka-ruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done @Ndunge-Makau

modalities: Capabilities.modalities_for(model_id),
capabilities: Capabilities.capabilities_for(model_id),
pricing: Capabilities.pricing_for(model_id),
metadata: Capabilities.determine_metadata(model_id)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants