Skip to content

Add with parameter to multimodal embeddings#4

Merged
Ndunge-Makau merged 2 commits intomainfrom
add-with-parameter-to-multimodal-embeddings
Jan 30, 2026
Merged

Add with parameter to multimodal embeddings#4
Ndunge-Makau merged 2 commits intomainfrom
add-with-parameter-to-multimodal-embeddings

Conversation

@Ndunge-Makau
Copy link
Owner

What this does

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Required for new features

  • I opened an issue before writing code and received maintainer approval
  • Linked issue: #529

PRs for new features or enhancements without a prior approved issue will be closed.

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
  • For provider changes: Re-recorded VCR cassettes with bundle exec rake vcr:record[provider_name]
  • All tests pass: bundle exec rspec
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

AI-generated code

  • I used AI tools to help write this code
  • I have reviewed and understand all generated code (required if above is checked)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

@Ndunge-Makau Ndunge-Makau merged commit a3b9b11 into main Jan 30, 2026
@Ndunge-Makau Ndunge-Makau deleted the add-with-parameter-to-multimodal-embeddings branch January 30, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant