Skip to content

Fix #2688: Add operation_name parameter to AWS Bedrock embedder configuration #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #2688: Add operation_name parameter to AWS Bedrock embedder configuration #2689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe33f90
Fix #2688: Add operation_name parameter to AWS Bedrock embedder confi…
devin-ai-integration[bot] Apr 25, 2025
b030400
Fix linting issue in test file
devin-ai-integration[bot] Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crewai/utilities/embedding_configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def _configure_bedrock(config, model_name):
)

# Allow custom model_name override with backwards compatibility
kwargs = {"session": config.get("session")}
kwargs = {"session": config.get("session"), "operation_name": "InvokeModel"}
if model_name is not None:
kwargs["model_name"] = model_name
return AmazonBedrockEmbeddingFunction(**kwargs)
Expand Down
21 changes: 21 additions & 0 deletions tests/utilities/test_embedding_configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import unittest
from unittest.mock import MagicMock, patch

from crewai.utilities.embedding_configurator import EmbeddingConfigurator


class TestEmbeddingConfigurator(unittest.TestCase):
@patch("chromadb.utils.embedding_functions.amazon_bedrock_embedding_function.AmazonBedrockEmbeddingFunction")
def test_configure_bedrock(self, mock_bedrock_embedder):
"""Test that the Bedrock embedder is configured correctly."""
config = {"session": MagicMock()}
model_name = "amazon.titan-embed-text-v1"

embedder = EmbeddingConfigurator()._configure_bedrock(config, model_name)

mock_bedrock_embedder.assert_called_once_with(
session=config["session"],
model_name=model_name,
operation_name="InvokeModel",
)
self.assertEqual(embedder, mock_bedrock_embedder.return_value)
Loading