Skip to content

Fix #2688: Add operation_name parameter to AWS Bedrock embedder configuration #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix AWS Bedrock Embedder in StringKnowledgeSource

Fixes #2688

Description

This PR fixes the error that occurs when using StringKnowledgeSource with a Bedrock embedder. The issue was a ClientError related to missing an 'operation_name' argument when creating the AmazonBedrockEmbeddingFunction.

Changes

  • Added the operation_name parameter to the AmazonBedrockEmbeddingFunction constructor
  • Added a unit test to verify the Bedrock embedder is configured correctly

Testing

  • Added a unit test to verify correct parameters are passed to the Bedrock embedder
  • Ran existing tests to ensure no regressions

Link to Devin run

https://app.devin.ai/sessions/27be1e5f46a24ef3ab79d0eee40cb78b

Requested by

Joe Moura (joao@crewai.com)

…guration

Co-Authored-By: Joe Moura <joao@crewai.com>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Co-Authored-By: Joe Moura <joao@crewai.com>
@btobio-switchfly
Copy link

Has this been updated yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]
1 participant