Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QE] limit log size for test reports #4403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[QE] limit log size for test reports #4403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions images/build-e2e/common/filter.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
<!-- identity transform -->
<xsl:template match="@*|node()">
<xsl:copy>
<xsl:apply-templates select="@*|node()"/>
<xsl:apply-templates select="@*|node()"/>
</xsl:copy>
</xsl:template>

<xsl:template match="failure">
<xsl:copy>
<xsl:value-of select="@message"/>
<xsl:value-of select="substring(@message,0,1000000)"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to pick the latest chars from the failure message.. It would have more sense as typically you see the error at the very end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the error is at the end...

is there a way to link to the full report or a compressed form?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, actually seems a combination of both: summary for the error at the beginning ...full trace with logs around the point of the error to the end of the trace.

Copy link
Contributor

@adrianriobo adrianriobo Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this made me think, the problem is about adding too much data on the junit files right?

Because it seems there is another option to import full logs next to results.... (on report portal)

If this is the case may we should see how to avoid the error log to be added on the junit file, for ginkgo AFAIK there are some customization you can do on the reporter to avoid the full trace... on the e2e side I think it is us adding the full error in code.

Can you check this @albfan

</xsl:copy>
</xsl:template>

Expand Down
4 changes: 2 additions & 2 deletions images/build-integration/common/filter.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
<!-- identity transform -->
<xsl:template match="@*|node()">
<xsl:copy>
<xsl:apply-templates select="@*|node()"/>
<xsl:apply-templates select="@*|node()"/>
</xsl:copy>
</xsl:template>

<xsl:template match="failure">
<xsl:copy>
<xsl:value-of select="@message"/>
<xsl:value-of select="substring(@message,0,1000000)"/>
</xsl:copy>
</xsl:template>

Expand Down
Loading