[QE] limit log size for test reports #4403
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| </xsl:copy> | ||
| </xsl:template> | ||
|
|
||
| <xsl:template match="failure"> | ||
| <xsl:copy> | ||
| <xsl:value-of select="@message"/> | ||
| <xsl:value-of select="substring(@message,0,1000000)"/> |
There was a problem hiding this comment.
Is it possible to pick the latest chars from the failure message.. It would have more sense as typically you see the error at the very end
There was a problem hiding this comment.
if the error is at the end...
is there a way to link to the full report or a compressed form?
There was a problem hiding this comment.
yeah, actually seems a combination of both: summary for the error at the beginning ...full trace with logs around the point of the error to the end of the trace.
There was a problem hiding this comment.
So this made me think, the problem is about adding too much data on the junit files right?
Because it seems there is another option to import full logs next to results.... (on report portal)
If this is the case may we should see how to avoid the error log to be added on the junit file, for ginkgo AFAIK there are some customization you can do on the reporter to avoid the full trace... on the e2e side I think it is us adding the full error in code.
Can you check this @albfan
|
@albfan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes: Issue #4373
Solution/Idea
Reports with long messages are hanging reportportal. Limit its size
Proposed changes
after post process xml report, limit log size
Testing
Tested on log reports long and short than max size