patchelf and rename -release tagged extensions from php configure build

[henderkes]

What does this PR do?

the release option also affects shared extensions, which is unwanted, patchelf their soname back and rename them

[crazywhalecc]

I got build error when building shared extension:

bin/spc build "" --build-shared=swoole --debug --build-cli --no-strip

configure:4185: clang -I/Users/jerry/project/git-project/static-php-cli/buildroot/include -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php/main -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php/TSRM -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php/Zend -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php/ext  -L/Users/jerry/project/git-project/static-php-cli/buildroot/lib conftest.c -Wl,-Bstatic -Wl,--start-group -lcares -lbrotlidec -lbrotlienc -lbrotlicommon -lz -lssl -lcrypto -lnghttp2 -lphp -lcurl -Wl,--end-group -Wl,-Bdynamic -lc -lpthread -lnghttp2 -framework CoreFoundation -framework CoreServices -framework SystemConfiguration -lresolv >&5
ld: unknown options: -Bstatic --start-group --end-group -Bdynamic 
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[Copilot]

Pull Request Overview

This PR addresses issues caused by the release option affecting shared PHP extensions. It updates tool checklists, modifies shared extension build operations to rename and update soname via patchelf, and adjusts file modifications conditional on a release flag.

• Added patchelf to various Linux tool lists.
• Modified the build process for shared extensions in LinuxBuilder.
• Adjusted file replacements in LibraryBase and updated logging in Extension.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/SPC/doctor/item/LinuxToolCheckList.php	Added 'patchelf' to tool lists for various Linux distributions.
src/SPC/builder/linux/LinuxBuilder.php	Renames shared extension files and uses patchelf to update soname.
src/SPC/builder/LibraryBase.php	Conditionally replaces lines in a source file based on a release flag.
src/SPC/builder/Extension.php	Adds shared extension build checks and logs warnings for build issues.
src/SPC/builder/BuilderBase.php	Removes redundant shared extension checks.

Comments suppressed due to low confidence (1)

src/SPC/builder/Extension.php:338

• [nitpick] Adjust the backtick formatting in the logged message so that the command is properly encapsulated (e.g. use a single pair: spc build).

logger()->warning('Try deleting your build and source folders and running `spc build`` again.');

[henderkes]

I got build error when building shared extension:

bin/spc build "" --build-shared=swoole --debug --build-cli --no-strip

configure:4185: clang -I/Users/jerry/project/git-project/static-php-cli/buildroot/include -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php/main -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php/TSRM -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php/Zend -I/Users/jerry/project/git-project/static-php-cli/buildroot/include/php/ext  -L/Users/jerry/project/git-project/static-php-cli/buildroot/lib conftest.c -Wl,-Bstatic -Wl,--start-group -lcares -lbrotlidec -lbrotlienc -lbrotlicommon -lz -lssl -lcrypto -lnghttp2 -lphp -lcurl -Wl,--end-group -Wl,-Bdynamic -lc -lpthread -lnghttp2 -framework CoreFoundation -framework CoreServices -framework SystemConfiguration -lresolv >&5
ld: unknown options: -Bstatic --start-group --end-group -Bdynamic 
clang: error: linker command failed with exit code 1 (use -v to see invocation)

ld64 doesn't understand a lot of the linker flags that lld/gnu-ld support. MacOS shared extension support is very much barebones and we're expecting .so files (which curiously, also get generated on macos, when I expected .dylibs). I was able to build shared extensions on MacOS by toying with linker flags a bit, but I only have a shitty hacked together docker environment and hate the MacOS keyboard scheme, so it's not a priority for me.

If you want to properly support shared extensions on mac, there's a lot of work to be done. Start group, end group for one is crucial, because by default, the linker doesn't go over previously visited archives again to find new unresolved symbols. We'd need to pass the libraries in perfect order, so that every library is only specified once, at the very last time that it needs to be referenced.

[henderkes]

closes #765

[crazywhalecc]

Removing LIBS=-Wl,-Bstatic ... seems to work fine on macOS so far.

$ ls -lah buildroot/modules/swoole.so
-rwxr-xr-x  1 jerry  staff    32M Jun 13 14:08 buildroot/modules/swoole.so

$ php -d "extension=buildroot/modules/swoole.so" --ri swoole

swoole

Swoole => enabled

$ otool -L buildroot/modules/swoole.so
buildroot/modules/swoole.so:
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1351.0.0)
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1900.180.0)

[henderkes]

You're welcome to remove it, it was mostly because it made testing easier in combination with --whole-archive, to force full resolution of symbols in those libraries. I think I edged it out with the new logic to find dependent libraries and the --start-group and --end-group-

[crazywhalecc]

It's a bit of a beast though. Next time it would be better to separate the dependencies to another PR - this would help reviewing and automatically generating changelogs, if it’s not too related.

In addition, it may be convenient for us to add a simple commit message detect workflow to trigger a single test function.