Skip to content

Python: Migrate to use "implicit namespace packages" (PEP 420) #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 4, 2024

Problem

ModuleNotFoundError: No module named 'crate.client'

More details:

Solution

Adjustments needed for harmonizing with the upcoming crate-1.0.0. It is only needed for future development operations.

The src layout helps prevent accidental usage of the in-development copy of the code.

-- https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/

References

Trivia

The change is not needed to satisfy runtime installations, #447 verifies that.

uv pip install --upgrade "crate>=1.0.0.dev2" crash
$ crash --version
0.31.5

/cc @surister, @simonprickett

@cla-bot cla-bot bot added the cla-signed label Nov 4, 2024
@amotl amotl force-pushed the crate-python-1.0.0 branch from 0bf47d7 to 5fcff41 Compare November 4, 2024 19:47
@amotl amotl requested review from mfussenegger and kneth November 4, 2024 19:50
amotl added 2 commits November 4, 2024 20:54
- Update keywords: Use `cratedb`
- Don't build universal wheels, Python 2 is a thing of the past
@amotl amotl force-pushed the crate-python-1.0.0 branch from 5fcff41 to 7034388 Compare November 4, 2024 19:54
@amotl amotl marked this pull request as ready for review November 4, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants