Skip to content

Fix compatibility issue with crate-0.30.0 when comparing versions #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

Fix compatibility issue with crate-0.30.0 when comparing versions #380

merged 1 commit into from
Feb 16, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 16, 2023 •
edited
Loading

This patch fixes a compatibility issue with the recently released crate-0.30.0 package, reported by @proddata. Thanks! It is related to:

File "/var/lib/jenkins/workspace/CrateDB/crate_test_hourly_master/blackbox/.venv/lib/python3.9/site-packages/crate/crash/command.py", line 401, in _fetch_session_info
    and self.connection.lowest_server_version >= StrictVersion("2.0"):
TypeError: '>=' not supported between instances of 'Version' and 'StrictVersion'

@amotl amotl force-pushed the amo/fix-crate-0.30.0 branch from 1c47d4a to 28a576e Compare February 16, 2023 17:21
@amotl amotl mentioned this pull request Feb 16, 2023
Merged
@amotl amotl requested review from matriv and proddata February 16, 2023 17:34
@amotl amotl marked this pull request as ready for review February 16, 2023 17:35
@amotl amotl force-pushed the amo/fix-crate-0.30.0 branch from 28a576e to dc6b7e5 Compare February 16, 2023 17:45
@amotl
Fix compatibility issue with crate-0.30.0 when comparing versions
6687a0d 
  self.connection.lowest_server_version >= StrictVersion("2.0"):
  TypeError: '>=' not supported between instances of 'Version' and 'StrictVersion'
@amotl amotl force-pushed the amo/fix-crate-0.30.0 branch from dc6b7e5 to 6687a0d Compare February 16, 2023 17:46
@amotl amotl requested a review from hramezani February 16, 2023 18:07
@amotl amotl merged commit c62e2ec into master Feb 16, 2023
@amotl amotl deleted the amo/fix-crate-0.30.0 branch February 16, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matriv matriv matriv approved these changes

@proddata proddata Awaiting requested review from proddata

@hramezani hramezani Awaiting requested review from hramezani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amotl @matriv