Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ctrl-d only quit program on empty command line #342

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Make ctrl-d only quit program on empty command line #342

merged 1 commit into from
Oct 19, 2020

Conversation

amotl
Copy link
Member

@amotl amotl commented Oct 19, 2020

Hi there,

thanks a bunch for conceiving and maintaining crash.

When starting to work with the program recently, it regularly occurred to me that I unintentionally quit the program by pressing CTRL-D. This improvement only quits the program when pressing CTRL-D on an empty command line. Otherwise, CTRL-D will act as the delete key, as we are used to it when working within other shells.

With kind regards,
Andreas.

P.S.: Unfortunately, I haven't been able to invoke the test suite. I hope this change doesn't break anything related to that. Let me know if this update needs any further adjustments.

Copy link
Member

@mfussenegger mfussenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 also happened to me from time to time. Nice change

Unfortunately, I haven't been able to invoke the test suite

What's the error/observed behavior?

Copy link
Contributor

@autophagy autophagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants