Merge pull request messagebird#114 from dzyanis/fix-unit-test

fixed alert text random order

Makefile

@@ -0,0 +1,14 @@
+linter:
+	./bin/golangci-lint run ./... --timeout=5m
+.PHONY: linter
+
+linter.download:
+	curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh
+.PHONY: linter.download
+
+test:
+	env CGO_ENABLED=1 go test -race ./...
+.PHONY: test
+
+alltest: linter test
+.PHONY: alltest

cmd/sachet/handlers.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"net/http"
+	"sort"
 	"strings"
 
 	"github.com/prometheus/alertmanager/template"
@@ -42,6 +43,7 @@ func newAlertText(data template.Data) string {
 		for k, v := range alert.Labels {
 			tuples = append(tuples, k+"= "+v)
 		}
+		sort.Strings(tuples)
 		return strings.ToUpper(data.Status) + " \n" + strings.Join(tuples, "\n")
 	}
 

cmd/sachet/handlers_test.go

@@ -30,7 +30,7 @@ func Test_newAlertText(t *testing.T) {
 			exp: " \n",
 		},
 		{
-			name: "alerts labels",
+			name: "alert labels",
 			data: template.Data{
 				Alerts: template.Alerts{
 					template.Alert{
@@ -42,7 +42,7 @@ func Test_newAlertText(t *testing.T) {
 					},
 				},
 			},
-			exp: " \nalertname= a\ninstance= a\nexported_instance= a",
+			exp: " \nalertname= a\nexported_instance= a\ninstance= a",
 		},
 		{
 			name: "common labels",