Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed alert text random order #114

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fixed alert text random order #114

merged 1 commit into from
Mar 23, 2022

Conversation

dzyanis
Copy link
Contributor

@dzyanis dzyanis commented Mar 18, 2022

  • Fixed unit-test Test_newAlertText by the solution from the example Iteration order
  • added Markefile

@marcelcorso marcelcorso merged commit 072afb6 into messagebird:master Mar 23, 2022
@marcelcorso
Copy link
Contributor

thanks @dzyanis !
I merged this but I will remove the Makefile later.

I hate makefiles 😂

You used it today but I'm not sure other people will later and it will just gather dust. Running linters and tests on CI is more scalable.

@dzyanis
Copy link
Contributor Author

dzyanis commented Mar 23, 2022

I merged this but I will remove the Makefile later

Up to you, you are the boss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzyanis @marcelcorso