Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add option to ignore creating dataset level node in default model #871

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

Remi-Gau
Copy link
Contributor

closes #831

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #871 (d7c6526) into main (9b5e2c4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
+ Coverage   78.77%   78.79%   +0.01%     
==========================================
  Files         238      238              
  Lines        6361     6367       +6     
  Branches       37       37              
==========================================
+ Hits         5011     5017       +6     
  Misses       1335     1335              
  Partials       15       15              
Flag Coverage Δ
cli 40.16% <ø> (ø)
matlab 80.12% <100.00%> (+0.01%) ⬆️
octave 78.73% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/parsers.py 87.50% <ø> (ø)
src/bids_model/createDefaultStatsModel.m 91.66% <100.00%> (+1.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 12, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 0.15 ⭐ 0.15 ⭐ 0.00
Method Length 105.40 🙂 105.60 🙂 0.20 👎
Working memory 2.60 ⭐ 2.60 ⭐ 0.00
Quality 76.97% 76.96% -0.01% 👎
Other metrics Before After Change
Lines 281 282 1
Changed files Quality Before Quality After Quality Change
src/parsers.py 76.97% ⭐ 76.96% ⭐ -0.01% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/parsers.py common_parser 0 ⭐ 390 ⛔ 2 ⭐ 68.13% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau Remi-Gau merged commit b014fee into cpp-lln-lab:main Dec 12, 2022
@Remi-Gau Remi-Gau deleted the model_ignore_dataset branch December 12, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create default model should also work for only subject level models
1 participant