Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] implement logger #867

Merged
merged 26 commits into from
Dec 10, 2022
Merged

[ENH] implement logger #867

merged 26 commits into from
Dec 10, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Dec 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #867 (2896bdd) into main (feeb676) will decrease coverage by 0.11%.
The diff coverage is 65.70%.

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   78.87%   78.76%   -0.12%     
==========================================
  Files         236      238       +2     
  Lines        6205     6361     +156     
  Branches       37       37              
==========================================
+ Hits         4894     5010     +116     
- Misses       1296     1336      +40     
  Partials       15       15              
Flag Coverage Δ
cli 40.16% <ø> (ø)
matlab 80.08% <65.04%> (-0.19%) ⬇️
octave 78.69% <62.83%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/IO/unzipAndReturnsFullpathName.m 58.82% <0.00%> (-3.68%) ⬇️
src/QA/anatomicalQA.m 0.00% <0.00%> (ø)
src/QA/functionalQA.m 0.00% <0.00%> (ø)
src/batches/preproc/setBatchCreateVDMs.m 84.00% <0.00%> (-1.72%) ⬇️
src/batches/preproc/setBatchGenerateT1map.m 74.32% <0.00%> (ø)
src/batches/preproc/setBatchRealign.m 94.91% <0.00%> (-3.34%) ⬇️
src/batches/preproc/setBatchSkullStripping.m 83.07% <0.00%> (-2.64%) ⬇️
src/batches/stats/setBatchGroupLevelContrasts.m 90.00% <0.00%> (ø)
src/batches/stats/setBatchSubjectLevelResults.m 47.61% <0.00%> (-5.02%) ⬇️
src/bids_model/checkContrast.m 50.00% <0.00%> (ø)
... and 99 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 9, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.75%.

Quality metrics Before After Change
Complexity 4.98 ⭐ 7.18 ⭐ 2.20 👎
Method Length 91.00 🙂 77.40 🙂 -13.60 👍
Working memory 6.41 🙂 7.78 🙂 1.37 👎
Quality 68.36% 🙂 66.61% 🙂 -1.75% 👎
Other metrics Before After Change
Lines 91 95 4
Changed files Quality Before Quality After Quality Change
docs/generate_doc.py 68.36% 🙂 66.61% 🙂 -1.75% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
docs/generate_doc.py append_dir_content 13 🙂 149 😞 12 😞 47.02% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau Remi-Gau merged commit 2d59ef2 into cpp-lln-lab:main Dec 10, 2022
@Remi-Gau Remi-Gau deleted the log branch December 12, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant