Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Nov 26, 2022

closes #834
closes #836

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 26, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 4.81%.

Quality metrics Before After Change
Complexity 8.56 🙂 7.09 ⭐ -1.47 👍
Method Length 90.88 🙂 86.84 🙂 -4.04 👍
Working memory 10.53 😞 9.23 🙂 -1.30 👍
Quality 58.55% 🙂 63.36% 🙂 4.81% 👍
Other metrics Before After Change
Lines 912 1006 94
Changed files Quality Before Quality After Quality Change
setup.py 90.22% ⭐ 95.18% ⭐ 4.96% 👍
demos/convert.py 25.40% 😞 25.14% 😞 -0.26% 👎
docs/generate_doc.py 68.45% 🙂 68.36% 🙂 -0.09% 👎
docs/source/conf.py 78.40% ⭐ 77.84% ⭐ -0.56% 👎
src/init.py % 98.67% ⭐ %
src/bidspm.py 38.40% 😞 54.08% 🙂 15.68% 👍
src/parsers.py 77.46% ⭐ 77.36% ⭐ -0.10% 👎
src/validate.py 78.41% ⭐ 78.38% ⭐ -0.03% 👎
tools/update_versions_bug_report.py 79.36% ⭐ 79.25% ⭐ -0.11% 👎
tools/validate_models.py 89.90% ⭐ 89.90% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/bidspm.py bidspm 13 🙂 283 ⛔ 24 ⛔ 27.27% 😞 Try splitting into smaller methods. Extract out complex expressions
src/bidspm.py stats 5 ⭐ 193 😞 22 ⛔ 40.63% 😞 Try splitting into smaller methods. Extract out complex expressions
src/bidspm.py preprocess 4 ⭐ 166 😞 18 ⛔ 46.47% 😞 Try splitting into smaller methods. Extract out complex expressions
src/bidspm.py cli 5 ⭐ 216 ⛔ 13 😞 47.11% 😞 Try splitting into smaller methods. Extract out complex expressions
docs/generate_doc.py append_dir_content 7 ⭐ 129 😞 10 😞 58.39% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau
Copy link
Contributor Author

pre-commit.ci autofix

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #837 (1c97fda) into main (20703d2) will decrease coverage by 1.41%.
The diff coverage is 40.15%.

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   78.20%   76.78%   -1.42%     
==========================================
  Files         230      235       +5     
  Lines        5932     6165     +233     
  Branches        0       34      +34     
==========================================
+ Hits         4639     4734      +95     
- Misses       1293     1416     +123     
- Partials        0       15      +15     
Flag Coverage Δ
cli 40.77% <40.15%> (?)
matlab 78.05% <ø> (ø)
octave 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/messages/bugReport.m 100.00% <ø> (ø)
src/validate.py 0.00% <0.00%> (ø)
src/bidspm.py 34.26% <35.39%> (ø)
src/matlab.py 66.66% <66.66%> (ø)
src/__init__.py 100.00% <100.00%> (ø)
src/parsers.py 87.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau merged commit 9a4c71c into cpp-lln-lab:main Nov 26, 2022
@Remi-Gau Remi-Gau deleted the docker branch November 26, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make python CLI call MATLAB and not just octave octave based docker image of the bids app

1 participant