Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Misc bug squashing 🐛 💀 #515

Merged
merged 7 commits into from
Feb 6, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 6, 2022

fixes #506
fixes #514

@Remi-Gau Remi-Gau changed the base branch from main to dev February 6, 2022 18:08
@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #515 (15e4b9b) into dev (c76e644) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #515      +/-   ##
==========================================
+ Coverage   72.99%   73.02%   +0.03%     
==========================================
  Files         192      192              
  Lines        4058     4060       +2     
==========================================
+ Hits         2962     2965       +3     
+ Misses       1096     1095       -1     
Flag Coverage Δ
unittests 73.02% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/IO/saveSpmScript.m 88.46% <100.00%> (+0.96%) ⬆️
src/infra/getEnvInfo.m 79.54% <100.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76e644...15e4b9b. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 418b16a into cpp-lln-lab:dev Feb 6, 2022
@Remi-Gau Remi-Gau deleted the misc-bug-squashing branch February 16, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant