Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 6, 2022

aims to fix #512

@Remi-Gau Remi-Gau changed the base branch from main to dev February 6, 2022 09:58
@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #513 (a9d7dff) into dev (ffa1fb1) will decrease coverage by 0.05%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #513      +/-   ##
==========================================
- Coverage   73.05%   72.99%   -0.06%     
==========================================
  Files         192      192              
  Lines        4052     4058       +6     
==========================================
+ Hits         2960     2962       +2     
- Misses       1092     1096       +4     
Flag Coverage Δ
unittests 72.99% <44.44%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/workflows/stats/bidsResults.m 44.44% <40.00%> (-0.56%) ⬇️
src/workflows/stats/bidsRFX.m 82.50% <50.00%> (-3.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa1fb1...a9d7dff. Read the comment docs.

run ../../initCppSpm.m;
catch
end
addpath(fullfile(pwd, '..', '..'));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore those "init" changes, they are unrelated to the fix.

Remi-Gau and others added 4 commits February 6, 2022 18:06
@@ -0,0 +1,57 @@
#! /user/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcobarilari

You might like this bash script.

[~, opt] = setUpWorkflow(opt, 'computing GLM results');
[BIDS, opt] = setUpWorkflow(opt, 'computing GLM results');

if isempty(opt.model.file)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's where the main error was coming from.

I had not thought that it would be possible to run Results and RFX with the default model. So now that should be possible.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 6, 2022

@marcobarilari

When all the test pass I will merge and ask you to test the bash script to see if you can run the whole "datalad" pipeline as well:
demos/vismotion/vismotion_demo.sh

@Remi-Gau Remi-Gau merged commit c76e644 into cpp-lln-lab:dev Feb 6, 2022
@marcobarilari
Copy link
Collaborator

Hey! Thanks yes I like the bash script 😂 so can I this one now?

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 7, 2022

Hey! Thanks yes I like the bash script joy so can I this one now?

yup just try to run it see if if goes through the whole thing without a hitch

@Remi-Gau Remi-Gau deleted the 512-fix_demo branch February 16, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: bidsResults does not work if default model

2 participants