-
Notifications
You must be signed in to change notification settings - Fork 15
[FIX] update vismotion demo #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #513 +/- ##
==========================================
- Coverage 73.05% 72.99% -0.06%
==========================================
Files 192 192
Lines 4052 4058 +6
==========================================
+ Hits 2960 2962 +2
- Misses 1092 1096 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* stats done * fix vismotion demo
for more information, see https://pre-commit.ci
| run ../../initCppSpm.m; | ||
| catch | ||
| end | ||
| addpath(fullfile(pwd, '..', '..')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore those "init" changes, they are unrelated to the fix.
* stats done * fix vismotion demo * remove default model and update the hand made one
for more information, see https://pre-commit.ci
| @@ -0,0 +1,57 @@ | |||
| #! /user/bin/bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might like this bash script.
| [~, opt] = setUpWorkflow(opt, 'computing GLM results'); | ||
| [BIDS, opt] = setUpWorkflow(opt, 'computing GLM results'); | ||
|
|
||
| if isempty(opt.model.file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's where the main error was coming from.
I had not thought that it would be possible to run Results and RFX with the default model. So now that should be possible.
|
When all the test pass I will merge and ask you to test the bash script to see if you can run the whole "datalad" pipeline as well: |
|
Hey! Thanks yes I like the bash script 😂 so can I this one now? |
yup just try to run it see if if goes through the whole thing without a hitch |
aims to fix #512