Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 5, 2022

No description provided.

@pep8speaks
Copy link

Hello @Remi-Gau! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 35:42: E711 comparison to None should be 'if cond is not None:'
Line 45:80: E501 line too long (90 > 79 characters)
Line 54:80: E501 line too long (86 > 79 characters)
Line 74:80: E501 line too long (81 > 79 characters)
Line 89:80: E501 line too long (95 > 79 characters)
Line 142:80: E501 line too long (85 > 79 characters)
Line 148:80: E501 line too long (88 > 79 characters)
Line 153:1: E305 expected 2 blank lines after class or function definition, found 1

@Remi-Gau Remi-Gau linked an issue Feb 5, 2022 that may be closed by this pull request
8 tasks
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #511 (9d9bd8b) into dev (238bf72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #511   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files         192      192           
  Lines        4052     4052           
=======================================
  Hits         2960     2960           
  Misses       1092     1092           
Flag Coverage Δ
unittests 73.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238bf72...9d9bd8b. Read the comment docs.

@Remi-Gau Remi-Gau merged commit ffa1fb1 into cpp-lln-lab:dev Feb 5, 2022
@Remi-Gau Remi-Gau changed the title [WIP] API design [ENH] start creating main API Feb 5, 2022
@Remi-Gau Remi-Gau deleted the API_design branch February 6, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create a cpp_spm main function in the root folder

2 participants