Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jan 3, 2022

Slice timing and repetition time metadata are not based on the value of the first subject anymore but are checked for each subject's files for slice timing correction and GLM specification.

Allows for metadata consistency checks as BIDS validation does not enforce that all files should have the same metadata: this is especially important when dealing with multitask workflows.

Related to #66 and #399

@Remi-Gau Remi-Gau changed the base branch from main to dev January 3, 2022 18:40
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #457 (4682e88) into dev (3db0b3e) will increase coverage by 0.65%.
The diff coverage is 89.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #457      +/-   ##
==========================================
+ Coverage   71.10%   71.75%   +0.65%     
==========================================
  Files         158      159       +1     
  Lines        3142     3186      +44     
==========================================
+ Hits         2234     2286      +52     
+ Misses        908      900       -8     
Flag Coverage Δ
unittests 71.75% <89.70%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/messages/createUnorderedList.m 100.00% <ø> (+61.53%) ⬆️
src/utils/getBoldFilename.m 77.77% <0.00%> (ø)
src/utils/getData.m 81.48% <ø> (+2.53%) ⬆️
src/workflows/roi/bidsCreateROI.m 0.00% <0.00%> (ø)
src/workflows/stats/bidsFFX.m 59.25% <0.00%> (-1.12%) ⬇️
src/batches/stats/setBatchSubjectLevelGLMSpec.m 90.47% <81.25%> (+1.14%) ⬆️
src/utils/getAndCheckSliceOrder.m 86.20% <86.20%> (ø)
src/utils/getAnatFilename.m 94.11% <87.50%> (+0.36%) ⬆️
src/utils/getInfo.m 97.05% <92.30%> (ø)
src/utils/getAndCheckRepetitionTime.m 93.75% <93.75%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db0b3e...4682e88. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 0c5b7fd into dev Jan 3, 2022
@Remi-Gau Remi-Gau deleted the remi_metadat_checks branch January 4, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants