Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

As far as I can tell this was only used once in the code base to unzip data, something that can be handled by base Matlab or Octave.

Also given that CPP_SPM is SPM based, the functionalities of Nifti tools should be implementable by using basic SPM functions and should not require another dependency.

@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #449 (ae57f44) into dev (9fd4d2f) will increase coverage by 0.00%.
The diff coverage is 64.70%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #449   +/-   ##
=======================================
  Coverage   69.58%   69.59%           
=======================================
  Files         158      158           
  Lines        3104     3098    -6     
=======================================
- Hits         2160     2156    -4     
+ Misses        944      942    -2     
Flag Coverage Δ
unittests 69.59% <64.70%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/infra/checkDependencies.m 66.66% <ø> (+3.03%) ⬆️
src/utils/validationInputFile.m 70.58% <ø> (ø)
src/utils/unzipAndReturnsFullpathName.m 57.14% <57.14%> (ø)
src/subject_level/getBoldFilenameForFFX.m 84.00% <100.00%> (ø)
src/utils/getAnatFilename.m 94.28% <100.00%> (ø)
src/utils/getBoldFilename.m 77.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd4d2f...ae57f44. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 19fde2c into dev Dec 25, 2021
@Remi-Gau Remi-Gau deleted the remi-drop_nifti_tools branch December 26, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants