Skip to content

Conversation

marcobarilari
Copy link
Collaborator

See #1006

@marcobarilari marcobarilari requested a review from Remi-Gau May 2, 2023 15:09
@marcobarilari marcobarilari added the bug 🐛 Something isn't working label May 2, 2023
@Remi-Gau Remi-Gau changed the title Force copy of data from fmriprep folder even if bidspm-preproc folder exists [Fix] Force copy of data from fmriprep folder even if bidspm-preproc folder exists May 2, 2023
@Remi-Gau Remi-Gau changed the title [Fix] Force copy of data from fmriprep folder even if bidspm-preproc folder exists [FIX] Force copy of data from fmriprep folder even if bidspm-preproc folder exists May 2, 2023
@Remi-Gau
Copy link
Contributor

Remi-Gau commented May 2, 2023

Let's wait for the ci to finish but looking good.

@Remi-Gau Remi-Gau marked this pull request as ready for review May 2, 2023 22:18
Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failure on octave is unrelated to this PR: it was there before.
I know I need to fix it.

So this PR can go in.

@Remi-Gau Remi-Gau merged commit f2f1dbe into cpp-lln-lab:main May 2, 2023
@marcobarilari marcobarilari deleted the marco_fix-#1006-copy-fmriprep branch July 15, 2024 14:13
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (05d92e9) to head (977d2b2).
Report is 206 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1009   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files         242      242           
  Lines        6594     6594           
  Branches       40       40           
=======================================
  Hits         5261     5261           
  Misses       1317     1317           
  Partials       16       16           
Flag Coverage Δ
cli 38.99% <ø> (ø)
matlab 81.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Data not found if running smoothing subject by subject with fmriprep output
2 participants