Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, apps): 'PacketDataProvider' interface added and implemented #4199

Merged
merged 18 commits into from
Aug 1, 2023
Merged

feat(core, apps): 'PacketDataProvider' interface added and implemented #4199

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
041476c
refactor(core/exported): moved packet interfaces to packet.go
srdtrk Jul 28, 2023
fc46e89
feat(core/exported): 'PacketDataProvider' interface added
srdtrk Jul 28, 2023
b6fe7fa
feat(transfer): PacketDataProvider implemented
srdtrk Jul 28, 2023
7b56d59
feat(ica): implemented PacketDataProvider
srdtrk Jul 28, 2023
83f7817
style(transfer_test, ica_test): improved test name
srdtrk Jul 28, 2023
e23b769
Merge branch 'main' into serdar/packetdataprovider
srdtrk Jul 28, 2023
5b01a89
merge: branch 'main' into serdar/packetdataprovider
srdtrk Aug 1, 2023
7173bab
docs(core.adr8): updated godocs
srdtrk Aug 1, 2023
950d77c
style(ica_test): changed a variable name
srdtrk Aug 1, 2023
3f382b0
docs(core.adr8): added missing '.'
srdtrk Aug 1, 2023
6fc5c26
imp(transfer): removed type assertion on jsonKey
srdtrk Aug 1, 2023
116a2db
fix(transfer_test): removed unused test case parameter
srdtrk Aug 1, 2023
c86405c
docs(transfer): updated godocs
srdtrk Aug 1, 2023
aa3fe0f
imp(ica): removed type assertion from 'GetCustomPacketData'
srdtrk Aug 1, 2023
11a859a
imp(transfer_test): improved tests without type assertion
srdtrk Aug 1, 2023
fbcf8b7
imp(ica_test): improved tests without type assertion
srdtrk Aug 1, 2023
fc5e953
style(transfer_test): changed test case parameter name
srdtrk Aug 1, 2023
7b9bfa2
merge: branch 'main' into serdar/packetdataprovider
srdtrk Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(transfer_test): removed unused test case parameter
  • Loading branch information
@srdtrk
srdtrk committed Aug 1, 2023
commit 116a2db37c4474aed2862a320cdf7e829cac7125
6 changes: 0 additions & 6 deletions modules/apps/transfer/types/packet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
name string
packetData types.FungibleTokenPacketData
expAdditionalData map[string]interface{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also maybe call expCustomData?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

expPacketSender string
}{
{
"success: src_callback key in memo",
Expand All @@ -64,7 +63,6 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
map[string]interface{}{
"address": receiver,
},
sender,
},
{
"success: src_callback key in memo with additional fields",
Expand All @@ -79,7 +77,6 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
"address": receiver,
"gas_limit": "200000",
},
sender,
},
{
"failure: empty memo",
Expand All @@ -91,7 +88,6 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
Memo: "",
},
nil,
sender,
},
{
"failure: non-json memo",
Expand All @@ -103,7 +99,6 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
Memo: "invalid",
},
nil,
sender,
},
{
"failure: invalid src_callback key",
Expand All @@ -115,7 +110,6 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
Memo: `{"src_callback": "invalid"}`,
},
nil,
sender,
},
}

Expand Down