feat(core, apps): 'PacketDataProvider' interface added and implemented #4199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
approved these changes
Jul 30, 2023
colin-axner
approved these changes
Jul 31, 2023
| testCases := []struct { | ||
| name string | ||
| packetData types.FungibleTokenPacketData | ||
| expAdditionalData map[string]interface{} |
There was a problem hiding this comment.
can also maybe call expCustomData?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4199 +/- ##
==========================================
+ Coverage 79.45% 79.47% +0.01%
==========================================
Files 188 188
Lines 12990 13025 +35
==========================================
+ Hits 10321 10351 +30
- Misses 2240 2243 +3
- Partials 429 431 +2
|
damiannolan
approved these changes
Aug 1, 2023
colin-axner
approved these changes
Aug 1, 2023
| testCases := []struct { | ||
| name string | ||
| packetData types.FungibleTokenPacketData | ||
| expAdditionalData interface{} |
There was a problem hiding this comment.
super super nit: expAdditionalData -> expCustomData
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
#4199) * refactor(core/exported): moved packet interfaces to packet.go * feat(core/exported): 'PacketDataProvider' interface added * feat(transfer): PacketDataProvider implemented * feat(ica): implemented PacketDataProvider * style(transfer_test, ica_test): improved test name * docs(core.adr8): updated godocs * style(ica_test): changed a variable name * docs(core.adr8): added missing '.' * imp(transfer): removed type assertion on jsonKey * fix(transfer_test): removed unused test case parameter * docs(transfer): updated godocs * imp(ica): removed type assertion from 'GetCustomPacketData' * imp(transfer_test): improved tests without type assertion * imp(ica_test): improved tests without type assertion * style(transfer_test): changed test case parameter name (cherry picked from commit a0a6526) # Conflicts: # modules/apps/27-interchain-accounts/types/packet.go # modules/apps/transfer/types/packet.go # modules/core/exported/channel.go
srdtrk
added a commit
that referenced
this pull request
Aug 2, 2023
…d (backport #4199) (#4218) * feat(core, apps): 'PacketDataProvider' interface added and implemented (#4199) * refactor(core/exported): moved packet interfaces to packet.go * feat(core/exported): 'PacketDataProvider' interface added * feat(transfer): PacketDataProvider implemented * feat(ica): implemented PacketDataProvider * style(transfer_test, ica_test): improved test name * docs(core.adr8): updated godocs * style(ica_test): changed a variable name * docs(core.adr8): added missing '.' * imp(transfer): removed type assertion on jsonKey * fix(transfer_test): removed unused test case parameter * docs(transfer): updated godocs * imp(ica): removed type assertion from 'GetCustomPacketData' * imp(transfer_test): improved tests without type assertion * imp(ica_test): improved tests without type assertion * style(transfer_test): changed test case parameter name (cherry picked from commit a0a6526) # Conflicts: # modules/apps/27-interchain-accounts/types/packet.go # modules/apps/transfer/types/packet.go # modules/core/exported/channel.go * fix: fixed backport conflicts * style: ran gofumpt * style(ica_test): typo fixed --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: srdtrk <srdtrk@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the diff when reviewing the adr8 PR #3939.
PacketDataProviderdefines an optional interfaces for retrieving custom packet data stored on behalf of another application.closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.