Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adr 8 callback packet data impl followups #3325

Merged
merged 36 commits into from
Mar 27, 2023
Merged

adr 8 callback packet data impl followups #3325

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
1bdb0e9
remove query client (#3227)
expertdicer Mar 14, 2023
be4c2d0
Rename ``IsBound`` to ``HasCapability`` (#3253)
expertdicer Mar 14, 2023
036565a
chore: add support for tendermint debug log level (#3279)
colin-axner Mar 14, 2023
80bab81
build(deps): bump cosmossdk.io/math from 1.0.0-beta.6.0.2023021617212…
dependabot[bot] Mar 14, 2023
2cb28d7
Write docker inspect output to diagnostics (#3291)
chatton Mar 14, 2023
02d8975
chore: fix dead links (#3293)
crodriguezvega Mar 14, 2023
796c7bc
build(deps): bump google.golang.org/protobuf from 1.29.0 to 1.29.1 (#…
dependabot[bot] Mar 15, 2023
71e8bf4
deps: bump SDK v0.47 (#3295)
crodriguezvega Mar 15, 2023
94d74f9
remove unnecessary import from doc
crodriguezvega Mar 15, 2023
b502f47
chore: remove support for v3 (#3294)
crodriguezvega Mar 17, 2023
6be595a
build(deps): bump actions/setup-go from 3 to 4 (#3307)
dependabot[bot] Mar 17, 2023
85faf55
imp: remove unnecessary defer func statements (#3304)
GNaD13 Mar 20, 2023
b4a386a
Remove gogoproto yaml tags from proto files (#3290)
hieuvubk Mar 20, 2023
b3f1b4d
add reasoning for migration to enable localhost
crodriguezvega Mar 20, 2023
cbb6859
Support configuration file for e2e tests (#3260)
chatton Mar 21, 2023
89ecf25
E2E fzf Test Selection Autocompletion (#3313)
chatton Mar 21, 2023
88f3c3c
post v7 release chores (#3310)
crodriguezvega Mar 21, 2023
5a67efc
chore: fix linter warnings (#3311)
crodriguezvega Mar 22, 2023
7d23e0f
ADR 008: IBC Actor Callbacks (#1976)
AdityaSripal Mar 22, 2023
8c16ce0
lint: fix spelling
colin-axner Mar 22, 2023
2818a57
chore: apply self review concerns
colin-axner Mar 22, 2023
8e8c64a
chore: rename CallbackPacketDataI to CallbackPacketData
colin-axner Mar 22, 2023
3cdc8b3
chore: finish applying remaining review suggestions
colin-axner Mar 22, 2023
be5a766
test: add remaining unit tests for transfer and ica
colin-axner Mar 22, 2023
767c5af
test: add unmarshaling test
colin-axner Mar 22, 2023
12c00ec
imp: address ADR 8 review suggestions (#3319)
colin-axner Mar 22, 2023
4961826
Bump interchain test (#3314)
chatton Mar 23, 2023
a02ec51
fix: remove codec registration
colin-axner Mar 23, 2023
6f25b8e
fix: build + linting
colin-axner Mar 23, 2023
f4c20e4
Only run e2e on R4R (#3330)
chatton Mar 23, 2023
8971ffc
fix fork workflows (#3328)
chatton Mar 23, 2023
1c6164b
Merge branch 'main' of github.com:cosmos/ibc-go into colin/callback-p…
colin-axner Mar 23, 2023
9435525
Revert "Merge branch 'main' of github.com:cosmos/ibc-go into colin/ca…
colin-axner Mar 23, 2023
7f88419
chore: add optional interface godoc
colin-axner Mar 23, 2023
935c5f0
Apply suggestions from code review
colin-axner Mar 27, 2023
a1252f3
chore: use backticks instead of escape characters in testing
colin-axner Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: use backticks instead of escape characters in testing
  • Loading branch information
@colin-axner
colin-axner committed Mar 27, 2023
commit a1252f3446fcf4fc88ba08ed79b09a18a056a550
12 changes: 6 additions & 6 deletions modules/apps/27-interchain-accounts/types/packet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
types.InterchainAccountPacketData{
Type: types.EXECUTE_TX,
Data: []byte("data"),
Memo: "{\"Key\": 10}",
Memo: `{"Key": 10}`,
},
false,
},
Expand All @@ -125,7 +125,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
types.InterchainAccountPacketData{
Type: types.EXECUTE_TX,
Data: []byte("data"),
Memo: "{\"callbacks\": {\"Key\": 10}}",
Memo: `{"callbacks": {"Key": 10}}`,
},
false,
},
Expand All @@ -134,7 +134,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
types.InterchainAccountPacketData{
Type: types.EXECUTE_TX,
Data: []byte("data"),
Memo: "{\"callbacks\": {\"src_callback_address\": 10}}",
Memo: `{"callbacks": {"src_callback_address": 10}}`,
},
false,
},
Expand All @@ -143,7 +143,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
types.InterchainAccountPacketData{
Type: types.EXECUTE_TX,
Data: []byte("data"),
Memo: fmt.Sprintf("{\"callbacks\": {\"src_callback_address\": \"%s\"}}", expSrcCbAddr),
Memo: fmt.Sprintf(`{"callbacks": {"src_callback_address": "%s"}}`, expSrcCbAddr),
},
true,
},
Expand Down Expand Up @@ -181,7 +181,7 @@ func (suite *TypesTestSuite) TestGetDestCallbackAddress() {
types.InterchainAccountPacketData{
Type: types.EXECUTE_TX,
Data: []byte("data"),
Memo: "{\"callbacks\": {\"dest_callback_address\": \"testAddress\"}}",
Memo: `{"callbacks": {"dest_callback_address": "testAddress"}}`,
},
},
}
Expand All @@ -199,7 +199,7 @@ func (suite *TypesTestSuite) TestUserDefinedGasLimit() {
packetData := types.InterchainAccountPacketData{
Type: types.EXECUTE_TX,
Data: []byte("data"),
Memo: "{\"callbacks\": {\"user_defined_gas_limit\": 100}}",
Memo: `{"callbacks": {"user_defined_gas_limit": 100}}`,
}

suite.Require().Equal(uint64(0), packetData.UserDefinedGasLimit(), "user defined gas limit does not return 0")
Expand Down
22 changes: 11 additions & 11 deletions modules/apps/transfer/types/packet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"Key\": 10}",
Memo: `{"Key": 10}`,
},
false,
},
Expand All @@ -91,7 +91,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"callbacks\": {\"Key\": 10}}",
Memo: `{"callbacks": {"Key": 10}}`,
},
false,
},
Expand All @@ -102,7 +102,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"callbacks\": {\"src_callback_address\": 10}}",
Memo: `{"callbacks": {"src_callback_address": 10}}`,
},
false,
},
Expand All @@ -113,7 +113,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"callbacks\": {\"src_callback_address\": \"testAddress\"}}",
Memo: `{"callbacks": {"src_callback_address": "testAddress"}}`,
},
false,
},
Expand All @@ -124,7 +124,7 @@ func (suite *TypesTestSuite) TestGetSourceCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: fmt.Sprintf("{\"callbacks\": {\"src_callback_address\": \"%s\"}}", addr1),
Memo: fmt.Sprintf(`{"callbacks": {"src_callback_address": "%s"}}`, addr1),
},
true,
},
Expand Down Expand Up @@ -179,7 +179,7 @@ func (suite *TypesTestSuite) TestGetDestCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"Key\": 10}",
Memo: `{"Key": 10}`,
},
false,
},
Expand All @@ -190,7 +190,7 @@ func (suite *TypesTestSuite) TestGetDestCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"callbacks\": {\"Key\": 10}}",
Memo: `{"callbacks": {"Key": 10}}`,
},
false,
},
Expand All @@ -201,7 +201,7 @@ func (suite *TypesTestSuite) TestGetDestCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"callbacks\": {\"dest_callback_address\": 10}}",
Memo: `{"callbacks": {"dest_callback_address": 10}}`,
},
false,
},
Expand All @@ -212,7 +212,7 @@ func (suite *TypesTestSuite) TestGetDestCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"callbacks\": {\"dest_callback_address\": \"testAddress\"}}",
Memo: `{"callbacks": {"dest_callback_address": "testAddress"}}`,
},
false,
},
Expand All @@ -223,7 +223,7 @@ func (suite *TypesTestSuite) TestGetDestCallbackAddress() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: fmt.Sprintf("{\"callbacks\": {\"dest_callback_address\": \"%s\"}}", addr2),
Memo: fmt.Sprintf(`{"callbacks": {"dest_callback_address": "%s"}}`, addr2),
},
true,
},
Expand All @@ -249,7 +249,7 @@ func (suite *TypesTestSuite) TestUserDefinedGasLimit() {
Amount: amount,
Sender: addr1,
Receiver: addr2,
Memo: "{\"callbacks\": {\"user_defined_gas_limit\": 100}}",
Memo: `{"callbacks": {"user_defined_gas_limit": 100}}`,
}

suite.Require().Equal(uint64(0), packetData.UserDefinedGasLimit(), "user defined gas limit does not return 0")
Expand Down