-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adr 8 callback packet data impl followups #3325
adr 8 callback packet data impl followups #3325
Commits on Mar 14, 2023
-
* remove query client * merge main * go mod tidy
Configuration menu - View commit details
-
Copy full SHA for 1bdb0e9 - Browse repository at this point
Copy the full SHA 1bdb0e9View commit details -
Rename
IsBound
toHasCapability
(#3253)## Description closes: #828 ### Commit Message / Changelog Entry ```bash imp(api!): rename `IsBound` to `HasCapability` for IBC application modules ``` see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples) --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)). - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package). - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`). - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review. - [ ] Re-reviewed `Files changed` in the Github PR explorer. - [ ] Review `Codecov Report` in the comment section below once CI passes.
Configuration menu - View commit details
-
Copy full SHA for be4c2d0 - Browse repository at this point
Copy the full SHA be4c2d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 036565a - Browse repository at this point
Copy the full SHA 036565aView commit details -
build(deps): bump cosmossdk.io/math from 1.0.0-beta.6.0.2023021617212…
…1-959ce49135e4 to 1.0.0-rc.0 (#3285) Bumps [cosmossdk.io/math](https://github.com/cosmos/cosmos-sdk) from 1.0.0-beta.6.0.20230216172121-959ce49135e4 to 1.0.0-rc.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/cosmos/cosmos-sdk/commits/math/v1.0.0-rc.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=cosmossdk.io/math&package-manager=go_modules&previous-version=1.0.0-beta.6.0.20230216172121-959ce49135e4&new-version=1.0.0-rc.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Configuration menu - View commit details
-
Copy full SHA for 80bab81 - Browse repository at this point
Copy the full SHA 80bab81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cb28d7 - Browse repository at this point
Copy the full SHA 2cb28d7View commit details -
## Description closes: #XXXX ### Commit Message / Changelog Entry ```bash type: commit message ``` see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples) --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)). - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package). - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`). - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review. - [x] Re-reviewed `Files changed` in the Github PR explorer. - [ ] Review `Codecov Report` in the comment section below once CI passes.
Configuration menu - View commit details
-
Copy full SHA for 02d8975 - Browse repository at this point
Copy the full SHA 02d8975View commit details
Commits on Mar 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 796c7bc - Browse repository at this point
Copy the full SHA 796c7bcView commit details -
Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 71e8bf4 - Browse repository at this point
Copy the full SHA 71e8bf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94d74f9 - Browse repository at this point
Copy the full SHA 94d74f9View commit details
Commits on Mar 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b502f47 - Browse repository at this point
Copy the full SHA b502f47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6be595a - Browse repository at this point
Copy the full SHA 6be595aView commit details
Commits on Mar 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 85faf55 - Browse repository at this point
Copy the full SHA 85faf55View commit details -
Remove gogoproto yaml tags from proto files (#3290)
## Description Refer from original issue, I removed all `yaml` tags in proto files. closes: #3145 ### Commit Message / Changelog Entry ```bash type: commit message ``` see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples) --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)). - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package). - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`). - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review. - [ ] Re-reviewed `Files changed` in the Github PR explorer. - [ ] Review `Codecov Report` in the comment section below once CI passes.
Configuration menu - View commit details
-
Copy full SHA for b4a386a - Browse repository at this point
Copy the full SHA b4a386aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3f1b4d - Browse repository at this point
Copy the full SHA b3f1b4dView commit details
Commits on Mar 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cbb6859 - Browse repository at this point
Copy the full SHA cbb6859View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89ecf25 - Browse repository at this point
Copy the full SHA 89ecf25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88f3c3c - Browse repository at this point
Copy the full SHA 88f3c3cView commit details
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5a67efc - Browse repository at this point
Copy the full SHA 5a67efcView commit details -
ADR 008: IBC Actor Callbacks (#1976)
* context and decision * complete adr * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * change from caller to generalized actor * Apply suggestions from code review Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * create folder and scaffolded middleware * add error handling and generify packetdata interface * complete renaming * add user defined gas limit and clarify pseudocode * Clarify CallbackPacketData interface imp: Add ADR 008: IBC Actor Callbacks --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7d23e0f - Browse repository at this point
Copy the full SHA 7d23e0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c16ce0 - Browse repository at this point
Copy the full SHA 8c16ce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2818a57 - Browse repository at this point
Copy the full SHA 2818a57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e8c64a - Browse repository at this point
Copy the full SHA 8e8c64aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cdc8b3 - Browse repository at this point
Copy the full SHA 3cdc8b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for be5a766 - Browse repository at this point
Copy the full SHA be5a766View commit details -
Configuration menu - View commit details
-
Copy full SHA for 767c5af - Browse repository at this point
Copy the full SHA 767c5afView commit details -
imp: address ADR 8 review suggestions (#3319)
--------- Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 12c00ec - Browse repository at this point
Copy the full SHA 12c00ecView commit details
Commits on Mar 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4961826 - Browse repository at this point
Copy the full SHA 4961826View commit details -
Configuration menu - View commit details
-
Copy full SHA for a02ec51 - Browse repository at this point
Copy the full SHA a02ec51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f25b8e - Browse repository at this point
Copy the full SHA 6f25b8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4c20e4 - Browse repository at this point
Copy the full SHA f4c20e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8971ffc - Browse repository at this point
Copy the full SHA 8971ffcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c6164b - Browse repository at this point
Copy the full SHA 1c6164bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9435525 - Browse repository at this point
Copy the full SHA 9435525View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f88419 - Browse repository at this point
Copy the full SHA 7f88419View commit details
Commits on Mar 27, 2023
-
Apply suggestions from code review
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Configuration menu - View commit details
-
Copy full SHA for 935c5f0 - Browse repository at this point
Copy the full SHA 935c5f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1252f3 - Browse repository at this point
Copy the full SHA a1252f3View commit details