Fix Timing Issues on UpdateClient #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
cwgoes
suggested changes
Mar 9, 2020
x/ibc/07-tendermint/update.go
Outdated
| @@ -85,6 +85,8 @@ func checkValidity( | |||
| } | |||
|
|
|||
| // Verify next header with the last header's validatorset as trusted validatorset | |||
| // TODO: Figure out a better way to add some leeway in currentTimestamp checking either in Tendermint or here | |||
There was a problem hiding this comment.
Per @melekes it sounds like this has just been fixed upstream, so let's remove this and instead update upstream?
| // assert header timestamp is not in the future (& transitively that is not past the trusting period) | ||
| if header.Time.Unix() > currentTimestamp.Unix() { | ||
| // assert header timestamp is not past the trusting period | ||
| if header.Time.Sub(clientState.GetLatestTimestamp()) >= clientState.TrustingPeriod { |
There was a problem hiding this comment.
Looks fine, see cosmos/ibc#390 (review).
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking the header against the local time introduces a lot of timing issues in the relayer. We can achieve the same security by explicitly checking if header.Timestamp has past trusting period.
ref @zmanian comment: cosmos/ibc#367 (comment)
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)