Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NextValidatorSet from the IBC Header #5763

Closed
wants to merge 3 commits into from

Conversation

AdityaSripal
Copy link
Member

Description

Removes NextValidatorSet from the Header and uses the current ValidatorSet of the lastHeader as trustedValSet in the lite.Verify function. This will make the relayer a lot simpler and less bug-prone


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@AdityaSripal AdityaSripal changed the base branch from master to ibc-alpha March 8, 2020 00:33
@cwgoes
Copy link
Contributor

cwgoes commented Mar 9, 2020

I can see how this makes things simpler. I think it will mean that we give up a bit of efficiency under bisection, right, since we're using a validator set one block behind the one we can actually trust? Are we concerned about that or not? (probably not too much)

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK modulo minor question

@@ -1,4 +1,6 @@
cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 h1:/vQbFIOMbk2FiG/kXiLl8BRyzTWDw7gX/Hz7Dd5eDMs=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change have to do with this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Believe this is something @jackzampolin wanted to remove that annoying warning notice whenever you build sdk on Mac

@cwgoes
Copy link
Contributor

cwgoes commented Mar 9, 2020

Is the test-cover failure something we need to be concerned about?

@AdityaSripal
Copy link
Member Author

Closed since #5764 incorporates these changes

@AdityaSripal AdityaSripal deleted the aditya/remove-nextvalset branch March 9, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants