Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add granularity options to pruning state #5709

Merged
merged 20 commits into from
Feb 28, 2020
Merged

Add granularity options to pruning state #5709

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ae14edc
add pre run command to check for prunning options
jgimeno Feb 27, 2020
0d8dade
add case for none set
jgimeno Feb 27, 2020
a6cd655
extract to function logic to check pruning params
jgimeno Feb 27, 2020
cfb3819
add function to get pruning options from flags
jgimeno Feb 27, 2020
2f55b9d
change default and fix test
jgimeno Feb 27, 2020
93e3f33
remove unused error
jgimeno Feb 27, 2020
9aeefa7
update command doc
jgimeno Feb 27, 2020
0c3117b
add godoc into GetPruningOptionsFromFlags
jgimeno Feb 27, 2020
2dbd364
update changelog
jgimeno Feb 27, 2020
0a3fcf6
change section in changelog
jgimeno Feb 27, 2020
a21a7fa
update test error lint
jgimeno Feb 27, 2020
fa3572e
update start cmd desc
jgimeno Feb 27, 2020
191664b
fix issue number
jgimeno Feb 27, 2020
f89fc6a
Merge branch 'master' into jonathan/5684-prune-syncable
jgimeno Feb 27, 2020
0027111
fix linter test
jgimeno Feb 27, 2020
3c26230
add more information into GetPruningOptionsFromFlags
jgimeno Feb 28, 2020
60970ba
update from PR comments
jgimeno Feb 28, 2020
56c0894
Merge branch 'master' into jonathan/5684-prune-syncable
alexanderbez Feb 28, 2020
2512930
Merge branch 'master' into jonathan/5684-prune-syncable
alexanderbez Feb 28, 2020
db855fb
Merge branch 'master' into jonathan/5684-prune-syncable
alexanderbez Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add more information into GetPruningOptionsFromFlags
  • Loading branch information
@jgimeno
jgimeno committed Feb 28, 2020
commit 3c262306fa943f22c033ea7e34fefa10bd17feb2
4 changes: 3 additions & 1 deletion server/pruning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import (
"github.com/spf13/viper"
)

//GetPruningOptionsFromFlags parses start command flags and returns the correct PruningOptions.
// GetPruningOptionsFromFlags parses start command flags and returns the correct PruningOptions.
// flagPruning prevails over flagPruningKeepEvery and flagPruningSnapshotEvery.
// Default option is PruneSyncable.
func GetPruningOptionsFromFlags() store.PruningOptions {
if viper.IsSet(flagPruning) {
return store.NewPruningOptionsFromString(viper.GetString(flagPruning))
Expand Down