-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add granularity options to pruning state #5709
Conversation
Even that it does not break back compatibility unless they use the new flags the new way to call SetPruning from gaia for example is:
instead of
So I don't know if it is worth it to deprecate the old NewPruningOptionsFromString, and later make it private. Ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comments only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpicks, but otherwise LGTM. Great job @jgimeno 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ☕️
Codecov Report
@@ Coverage Diff @@
## master #5709 +/- ##
=========================================
+ Coverage 35.47% 35.7% +0.22%
=========================================
Files 333 335 +2
Lines 32604 32695 +91
=========================================
+ Hits 11566 11673 +107
+ Misses 19816 19790 -26
- Partials 1222 1232 +10
|
Closes: #5684
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)