Revert "changed bench32prefixes, gaiacli keys parse command still use cosmos …" #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5a310fa.
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
alessio
approved these changes
Nov 6, 2019
|
@elvin-du we use a global singleton (bad) for the config. We should ideally remove the singleton in favor of a more dynamic approach. This is probably causing some sort of race condition. |
fedekunze
approved these changes
Nov 6, 2019
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #5283 +/- ##
=========================================
Coverage ? 53.49%
=========================================
Files ? 290
Lines ? 17771
Branches ? 0
=========================================
Hits ? 9507
Misses ? 7513
Partials ? 751 |
boz
added a commit
to akash-network/cosmos-sdk
that referenced
this pull request
May 8, 2020
`keys parse` uses the global configuration before before client applications have had a chance to apply their settings. This change adds a `GetSealedConfig()` helper that waits for the config to be sealed before returning it. fixes cosmos#5091 addresses cosmos#5283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5092 due to race condition (e.g. here)
/cc @elvin-du any chance you can look into this?