changed bench32prefixes, gaiacli keys parse command still use cosmos … #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvin-du
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
golangcibot
reviewed
Sep 24, 2019
alessio
previously requested changes
Sep 24, 2019
alexanderbez
suggested changes
Sep 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #5092 +/- ##
=========================================
Coverage ? 54.87%
=========================================
Files ? 295
Lines ? 18271
Branches ? 0
=========================================
Hits ? 10027
Misses ? 7495
Partials ? 749 |
|
bump @elvin-du |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
|
Thanks @elvin-du. Mind resolving the changelog conflict quickly? |
alexanderbez
added a commit
that referenced
this pull request
Nov 6, 2019
This reverts commit 5a310fa.
alexanderbez
added a commit
that referenced
this pull request
Nov 6, 2019
This reverts commit 5a310fa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5091
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: