Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mircea/update contributing md #4205

Merged
merged 5 commits into from
Apr 27, 2019
Merged

Conversation

mircea-c
Copy link

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- one minor nit.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #4205 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4205      +/-   ##
==========================================
- Coverage   60.17%   60.16%   -0.02%     
==========================================
  Files         212      212              
  Lines       15187    15187              
==========================================
- Hits         9139     9137       -2     
- Misses       5419     5421       +2     
  Partials      629      629

@alexanderbez alexanderbez mentioned this pull request Apr 26, 2019
5 tasks
Co-Authored-By: mircea-c <mircea@tendermint.com>
@rigelrozanski rigelrozanski merged commit 36dcd7b into master Apr 27, 2019
@rigelrozanski rigelrozanski deleted the mircea/update-contributing-md branch April 27, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants