Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mircea/update contributing md #4202

Closed
wants to merge 3 commits into from
Closed

Conversation

mircea-c
Copy link

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mircea-c mircea-c marked this pull request as ready for review April 26, 2019 17:41
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #4202 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4202      +/-   ##
===========================================
+ Coverage    60.16%   60.17%   +0.01%     
===========================================
  Files          212      212              
  Lines        15187    15187              
===========================================
+ Hits          9137     9139       +2     
+ Misses        5421     5419       -2     
  Partials       629      629

@alexanderbez
Copy link
Contributor

/cc @yangyanqing

@ebuchman ebuchman closed this Apr 26, 2019
@yangyanqing
Copy link
Contributor

Got it ! @alexanderbez

@yangyanqing
Copy link
Contributor

This PR had not been merged into master. @alexanderbez @mircea-c

@alexanderbez
Copy link
Contributor

@yangyanqing => #4205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants