-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading dependencies #3962
Upgrading dependencies #3962
Conversation
Do we have any way to test ledger integration in CI? |
Also why aren't we using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use https://github.com/cosmos/ledger-go instead of the fork?
@cwgoes Yes, sure. I will push the missing changes to |
Thanks - just trying to keep our dependency graph as sane as possible. |
Maybe we could extend this to CLI use cases too. |
5584213
to
95fba6a
Compare
@cwgoes dependencies updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, thanks @jleni
95fba6a
to
751787f
Compare
When a ledger device tries to sign a transaction and considers the message invalid, it generates a more specific error message than what it is being shown in the CLI.
Expose this error message.
Fixes are applied in the corresponding dependencies:
Zondax/ledger-cosmos-go#26
Zondax/ledger-go#7
Closes #3959
docs/
)sdkch add [section] [stanza] [message]
Files changed
in the github PR explorerFor Admin Use: