Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Tags Cleanup & Docs #3137

Merged
merged 15 commits into from
Dec 20, 2018
Merged

R4R: Tags Cleanup & Docs #3137

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
020cbd1
Remove dup tags from x/gov EndBlocker
Dec 17, 2018
ba70cc4
Remove dup tag from x/slashing BeginBlocker
Dec 17, 2018
3b78313
Create tags sub package in slashing module and use new height tag
Dec 18, 2018
cb37b10
Merge branch 'develop' into bez/2448-quick-n-dirty-events
Dec 18, 2018
39b8d66
Actually de-dep governance tags + add tags docs for gov module
Dec 18, 2018
51918dc
Update slashing tags and add docs
Dec 19, 2018
6f5f648
Update x/gov tags and docs
Dec 19, 2018
241fef9
Update staking tags and implement tags doc
Dec 19, 2018
d7df055
Add delegation module tags doc
Dec 19, 2018
2bf8bf9
Add banking module tags doc
Dec 19, 2018
8110d5f
Minor cleanup
Dec 19, 2018
a6294dc
Fix docs
Dec 19, 2018
3ee301f
Add pending log entry
Dec 19, 2018
fe98ba7
Merge branch 'develop' into bez/2448-quick-n-dirty-events
Dec 19, 2018
781b1aa
Add back proposal ID tag to gov EndBlocker
Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove dup tag from x/slashing BeginBlocker
  • Loading branch information
Aleksandr Bezobchuk committed Dec 17, 2018
commit ba70cc449df853a8ae44221d09df58a0228ef207
11 changes: 3 additions & 8 deletions x/slashing/tick.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package slashing

import (
"encoding/binary"
"fmt"

abci "github.com/tendermint/tendermint/abci/types"
Expand All @@ -11,12 +10,8 @@ import (
)

// slashing begin block functionality
func BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock, sk Keeper) (tags sdk.Tags) {

// Tag the height
heightBytes := make([]byte, 8)
binary.LittleEndian.PutUint64(heightBytes, uint64(req.Header.Height))
tags = sdk.NewTags("height", heightBytes)
func BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock, sk Keeper) sdk.Tags {
tags := sdk.NewTags("slashing-height", []byte(fmt.Sprintf("%d", req.Header.Height)))

// Iterate over all the validators which *should* have signed this block
// store whether or not they have actually signed it and slash/unbond any
Expand All @@ -37,5 +32,5 @@ func BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock, sk Keeper) (tags
}
}

return
return tags
}