R4R: Tags Cleanup & Docs

[alexanderbez]

• Fixed certain tag values (not using Amino to marshal because clients should not have to do this!)
• Updated slashing modules tags
• Added a tags doc for each module to provide details on key expected event/tag for both handlers and begin/end blockers

---

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #3137 into develop will increase coverage by 0.04%.
The diff coverage is 96.77%.

@@             Coverage Diff             @@
##           develop    #3137      +/-   ##
===========================================
+ Coverage    55.03%   55.07%   +0.04%     
===========================================
  Files          133      133              
  Lines         9438     9443       +5     
===========================================
+ Hits          5194     5201       +7     
+ Misses        3924     3922       -2     
  Partials       320      320

[alexanderbez]

@cwgoes I decided to address #2448 into two PRs in the spirit of trying to keep our PRs small and tidy.

Namely, this PR simply does some cleanup and more importantly creates tags/events documentation for each module. A second PR, #3171, will be to actually implement a simple event manager.

So this is R4R.

[jackzampolin]

Is there a reason why we don't tag every message with it's type? Or do we and that isn't mentioned here?

[alexanderbez]

We do:

# baseapp.go#L:624
tags = append(tags, sdk.MakeTag(sdk.TagAction, []byte(msg.Type())))

I will be changing this in #3171 to be message-type instead of action so I'd rather do that in the aforementioned PR (i.e have this merged first).

[jackzampolin]

What does this mean? All governance events are tagged with these?

[alexanderbez]

Exactly.

[jackzampolin]

A couple of small questions, but looks good to me!

[cwgoes]

Tested ACK