Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix struct field name and some typos in comment #23126

Merged
merged 4 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/rfc/rfc-003-crosslang.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ These bytes can be used by the **state handler** to determine what type of state

A **state token** is an opaque array of 32-bytes that is passed in each message request.
The hypervisor has no knowledge of what this token represents or how it is created,
but it is expected that modules that mange state do understand this token and use it to manage all state changes
but it is expected that modules that manage state do understand this token and use it to manage all state changes

This comment was marked as spam.

in consistent transactions.
All side effects regarding state, events, etc. are expected to coordinate around the usage of this token.
It is possible that state modules expose methods for creating new **state tokens**
Expand Down
2 changes: 1 addition & 1 deletion schema/testing/statesim/module_diff.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func DiffModuleStates(expected, actual view.ModuleState) string {
continue
}
if actualColl == nil {
res += fmt.Sprintf("Object Collection %s: actuall collection NOT FOUND\n", objTypeName)
res += fmt.Sprintf("Object Collection %s: actual collection NOT FOUND\n", objTypeName)

This comment was marked as spam.

continue
}

Expand Down
2 changes: 1 addition & 1 deletion simapp/v2/export.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

// ExportAppStateAndValidators exports the state of the application for a genesis
// file.
// This is a demonstation of how to export a genesis file. Export may need extended at
// This is a demonstration of how to export a genesis file. Export may need extended at
// the user discretion for cleaning the genesis state at the end provided with jailAllowedAddrs
// Same applies for forZeroHeight preprocessing.
func (app *SimApp[T]) ExportAppStateAndValidators(
Expand Down
2 changes: 1 addition & 1 deletion x/auth/ante/unordered.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var _ sdk.AnteDecorator = (*UnorderedTxDecorator)(nil)
// The UnorderedTxDecorator should be placed as early as possible in the AnteHandler
// chain to ensure that during DeliverTx, the transaction is added to the UnorderedTxManager.
type UnorderedTxDecorator struct {
// maxUnOrderedTTL defines the maximum TTL a transaction can define.
// maxTimeoutDuration defines the maximum TTL a transaction can define.

This comment was marked as spam.

maxTimeoutDuration time.Duration
txManager *unorderedtx.Manager
env appmodulev2.Environment
Expand Down
2 changes: 1 addition & 1 deletion x/tx/decode/unknown.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func doRejectUnknownFields(
}
// if a message descriptor is a placeholder resolve it using the injected resolver.
// this can happen when a descriptor has been registered in the
// "google.golang.org/protobuf" resgistry but not in "github.com/cosmos/gogoproto".
// "google.golang.org/protobuf" registry but not in "github.com/cosmos/gogoproto".

This comment was marked as spam.

// fixes: https://github.com/cosmos/cosmos-sdk/issues/22574
if fieldMessage.IsPlaceholder() {
gogoDesc, err := resolver.FindDescriptorByName(fieldMessage.FullName())
Expand Down
Loading