Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use alpine in dockerfile #15703

Merged
merged 10 commits into from
Apr 6, 2023
Merged

ci: use alpine in dockerfile #15703

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
75a8611
ci: use right link in docker job
julienrbrt Apr 5, 2023
cf8e2d6
updates
julienrbrt Apr 5, 2023
0e1c440
updates
julienrbrt Apr 5, 2023
7cc101d
updates
julienrbrt Apr 5, 2023
a0eafc8
Merge branch 'main' into julien/docker-ci
julienrbrt Apr 5, 2023
f716661
updates
julienrbrt Apr 5, 2023
59204a7
Merge branch 'main' into julien/docker-ci
julienrbrt Apr 5, 2023
c610b97
update docker metadata
julienrbrt Apr 6, 2023
5053343
Merge branch 'main' into julien/docker-ci
julienrbrt Apr 6, 2023
215ef5b
updates
julienrbrt Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Build & Push
# Build & Push builds the simapp docker image on every push to main and
# and pushes the image to https://hub.docker.com/r/interchainio/simapp/tags
# and pushes the image to https://ghcr.io/cosmos/simapp
on:
pull_request:
paths:
Expand All @@ -11,6 +11,12 @@ on:
tags:
- "v[0-9]+.[0-9]+.[0-9]+" # Push events to matching v*, i.e. v1.0, v20.15.10
- "v[0-9]+.[0-9]+.[0-9]+-rc*" # Push events to matching v*, i.e. v1.0-rc1, v20.15.10-rc5
workflow_dispatch:
julienrbrt marked this conversation as resolved.
Show resolved Hide resolved
inputs:
tags:
description: "SDK version (e.g 0.47.1)"
required: true
type: string

permissions:
contents: read
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
# Client: (Note the simapp binary always looks at ~/.simapp we can bind to different local storage)
# > docker run -it -p 26657:26657 -p 26656:26656 -v ~/.simappcli:/root/.simapp simapp simd keys add foo
# > docker run -it -p 26657:26657 -p 26656:26656 -v ~/.simappcli:/root/.simapp simapp simd keys list
# TODO: demo connecting rest-server (or is this in server now?)
#
# This image is pushed to the GHCR as https://ghcr.io/cosmos/simapp

# bullseye already comes with build dependencies, so we don't need anything extra to install
FROM --platform=$BUILDPLATFORM golang:1.20-bullseye AS build-env
Expand All @@ -35,9 +36,8 @@ ARG TARGETOS TARGETARCH
# install simapp, remove packages
RUN GOOS=$TARGETOS GOARCH=$TARGETARCH make build


# Final image, without build artifacts. `/base` already contains openssl, glibc and all required libs to start an app
FROM gcr.io/distroless/base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasnt this added on purpose? why are we reverting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in #14793 next to other improvements (which made the image lighter).

Turns out, users need to have the extra commands in the alpine image #15672.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, nice change. alpine:3 should be a great trade-off. Slim enough and you can install the rest via package management.

# Use alpine:3 as a base image
FROM alpine:3

EXPOSE 26656 26657 1317 9090
# Run simd by default, omit entrypoint to ease using container with simcli
Expand Down