ci: use alpine in dockerfile #15703
Merged
ci: use alpine in dockerfile #15703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
mark-rushakoff and
facundomedica
and removed request for
a team
julienrbrt
changed the title
julienrbrt
added
the
backport/v0.47.x
tac0turtle
reviewed
Apr 5, 2023
| @@ -35,9 +36,8 @@ ARG TARGETOS TARGETARCH | |||
| # install simapp, remove packages | |||
| RUN GOOS=$TARGETOS GOARCH=$TARGETARCH make build | |||
|
|
|||
|
|
|||
| # Final image, without build artifacts. `/base` already contains openssl, glibc and all required libs to start an app | |||
| FROM gcr.io/distroless/base | |||
There was a problem hiding this comment.
wasnt this added on purpose? why are we reverting?
There was a problem hiding this comment.
Thank you, nice change. alpine:3 should be a great trade-off. Slim enough and you can install the rest via package management.
19 tasks
|
Checking how to configure the |
julienrbrt
commented
Apr 5, 2023
mark-rushakoff
approved these changes
Apr 5, 2023
|
tACK on a fork |
mergify bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
(cherry picked from commit b2c8418) # Conflicts: # .github/workflows/docker.yml
IMO the best way is
|
julienrbrt
added a commit
that referenced
this pull request
Apr 6, 2023
So I well tested that the tagging and all worked well, but I didn't actually test that the distro change was working 🤦♂️... follow up incoming. |
19 tasks
roy-dydx
pushed a commit
to dydxprotocol/cosmos-sdk
that referenced
this pull request
Jul 11, 2023
…) (cosmos#15718) Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #15672
What is the best way to deprecate https://hub.docker.com/r/interchainio/simapp?
Can someone modify the overview here: https://hub.docker.com/r/interchainio/simapp and link it to https://ghcr.io/cosmos/simapp?
First merge this: #15702 and then this one.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change