Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Better error msgs when node isn't synced #11449

Merged
merged 11 commits into from
Mar 25, 2022
Merged

chore: Better error msgs when node isn't synced #11449

Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
418a335
better err msg by checking node height
likhita-809 Mar 24, 2022
46f2b2d
get node sync info and check for catching up
likhita-809 Mar 24, 2022
293cd0a
small fix
likhita-809 Mar 24, 2022
cc455cb
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…
likhita-809 Mar 24, 2022
3b818e4
small fix
likhita-809 Mar 25, 2022
c45dcfd
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…
likhita-809 Mar 25, 2022
42ad8f7
fix test
likhita-809 Mar 25, 2022
799b0b6
Merge branch 'master' into likhita/better-err-msgs-3412
tac0turtle Mar 25, 2022
1802d51
add changelog
likhita-809 Mar 25, 2022
354f571
Merge branch 'master' into likhita/better-err-msgs-3412
tac0turtle Mar 25, 2022
83d5014
Merge branch 'master' into likhita/better-err-msgs-3412
likhita-809 Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions x/auth/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,18 @@ func GetAccountCmd() *cobra.Command {
queryClient := types.NewQueryClient(clientCtx)
res, err := queryClient.Account(cmd.Context(), &types.QueryAccountRequest{Address: key.String()})
if err != nil {
node, err2 := clientCtx.GetNode()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use err2, you can safely shadow the existing err

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a case, where we have an err from L101 and err returned as nil from L103 and L107 and catchingUp is false, then err would be nil which isn't true. I think having a separate variable makes sense here.

if err2 != nil {
return err2
}
status, err2 := node.Status(context.Background())
if err2 != nil {
return err2
}
catchingUp := status.SyncInfo.CatchingUp
if !catchingUp {
return errors.Wrapf(err, "your node may be syncing, please check node status using `/status`")
}
return err
}

Expand Down