chore: Better error msgs when node isn't synced #11449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,6 +100,19 @@ func GetAccountCmd() *cobra.Command { | |||
| queryClient := types.NewQueryClient(clientCtx) | |||
| res, err := queryClient.Account(cmd.Context(), &types.QueryAccountRequest{Address: key.String()}) | |||
| if err != nil { | |||
| node, err2 := clientCtx.GetNode() | |||
There was a problem hiding this comment.
No need to use err2, you can safely shadow the existing err
There was a problem hiding this comment.
In a case, where we have an err from L101 and err returned as nil from L103 and L107 and catchingUp is false, then err would be nil which isn't true. I think having a separate variable makes sense here.
…khita/better-err-msgs-3412
likhita-809
requested review from
atheeshp,
aleem1314,
amaury1093,
anilcse,
blushi and
tac0turtle
atheeshp
approved these changes
Mar 25, 2022
tac0turtle
approved these changes
Mar 25, 2022
|
Nice! Let's maybe add a changelog? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #3412
In this PR, we get node syncing info to check if it is catching up and added a better msg along with the error obtained
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change