-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: move test-race to its own job #10895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to optimize it then the better strategy is to avoid duplicated runs:
- run all race tests
- run other tests which were not run with race tests (to not duplicate).
I don't get which part of this is not being done. We are running the tests that can't be run in the race detector in tests and the ones that can here. This isn't meant as a speed up. We need to redo the test suite to fix this imo. |
The second bullet point. We are duplicate test runs. We will need some smarter script to do it. |
So if this PR won't speed up anything, then what's the improvement? |
as its stated in the description, if normal tests fail there is no need to rerun 10 odd jobs, but only need to rerun 4-5. This reduces the amount of jobs running when rerunning things which unblocks runners for other jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is there a way to re run only one job? I have never seen that option.
I'm not against this PR, so approving, but let's clarify how to use it / take benefit of it.
I created a task for the optimization I mentioned: #10913 |
Description
moving test-race to its own job allows us to run it or normal tests on their own. this reduces running jobs. The down side is if they both fail we then have to rerun both of them.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change