Remove duplicated test runs in "no race" mode

[robert-zaremba]

Summary

Today, with test-unit we run tests which are run in test-race. So we duplicate test runs.

Proposal

When running tests in CI:

• run all race tests
• run other tests which were not run with race tests (to not duplicate test runs).

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[tac0turtle]

do you think its worth rethinking how we do integration tests instead of this? I don't think we need multiple instances of tendermint in tests?

[alexanderbez]

There are many circumstances where we need multiple validators to effectively test certain cases. So I don't enforcing a single validator is a viable option.

Also, the race condition comes from the fact that we can run multiple integration tests at once, not multiple validators at once.

[robert-zaremba]

do you think its worth rethinking how we do integration tests instead of this?

Integration tests should be refactored anyway (there is too much boilerplate).
I think we should use race tests whenever possible. There is no need to duplicate test runs if a test was already executed in the 'race' mode.

[tac0turtle]

interestingly enough the issue is with goleveldb. We are using it in a concurrent way but goleveldb is purposefully meant to not do this.

I think there is a way to avoid this, but need to dig into the repo.

[tac0turtle]

closed