-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve ingester state on restart #6301
Open
alexqyle
wants to merge
3
commits into
cortexproject:master
Choose a base branch
from
alexqyle:preserve-ingester-state
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+221
−132
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| package ring | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "errors" | ||
| "os" | ||
| "sort" | ||
| ) | ||
|
|
||
| type TokenFile struct { | ||
| PreviousState InstanceState `json:"previousState"` | ||
| Tokens Tokens `json:"tokens"` | ||
| } | ||
|
|
||
| // StoreToFile stores the tokens in the given directory. | ||
| func (l TokenFile) StoreToFile(tokenFilePath string) error { | ||
| if tokenFilePath == "" { | ||
| return errors.New("path is empty") | ||
| } | ||
|
|
||
| // If any operations failed further in the function, we keep the temporary | ||
| // file hanging around for debugging. | ||
| f, err := os.Create(tokenFilePath + ".tmp") | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| defer func() { | ||
| // If the file was not closed, then there must already be an error, hence ignore | ||
| // the error (if any) from f.Close(). If the file was already closed, then | ||
| // we would ignore the error in that case too. | ||
| _ = f.Close() | ||
| }() | ||
|
|
||
| b, err := json.Marshal(l) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if _, err = f.Write(b); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err := f.Close(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Tokens successfully written, replace the temporary file with the actual file path. | ||
| return os.Rename(f.Name(), tokenFilePath) | ||
| } | ||
|
|
||
| func LoadTokenFile(tokenFilePath string) (*TokenFile, error) { | ||
| b, err := os.ReadFile(tokenFilePath) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| t := TokenFile{} | ||
| err = json.Unmarshal(b, &t) | ||
|
|
||
| // Tokens may have been written to file by an older version which | ||
| // doesn't guarantee sorted tokens, so we enforce sorting here. | ||
| if !sort.IsSorted(t.Tokens) { | ||
| sort.Sort(t.Tokens) | ||
| } | ||
|
|
||
| return &t, err | ||
| } | ||
|
|
||
| func (p InstanceState) MarshalJSON() ([]byte, error) { | ||
| ss := InstanceState_name[int32(p)] | ||
| return json.Marshal(ss) | ||
| } | ||
| func (p *InstanceState) UnmarshalJSON(data []byte) error { | ||
| res := "" | ||
| if err := json.Unmarshal(data, &res); err != nil { | ||
| return err | ||
| } | ||
| *p = InstanceState(InstanceState_value[res]) | ||
| return nil | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update those comments? TransferChunks is from the old chunks store.