Preserve ingester state on restart #6301
Open
+221
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oin ring with previous state Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
alanprot
reviewed
Nov 1, 2024
| @@ -911,7 +961,9 @@ func (i *Lifecycler) changeState(ctx context.Context, state InstanceState) error | |||
| if !((currState == PENDING && state == JOINING) || // triggered by TransferChunks at the beginning | |||
| (currState == JOINING && state == PENDING) || // triggered by TransferChunks on failure | |||
| (currState == JOINING && state == ACTIVE) || // triggered by TransferChunks on success | |||
| (currState == JOINING && state == READONLY) || // triggered by TransferChunks on success | |||
There was a problem hiding this comment.
Can we update those comments? TransferChunks is from the old chunks store.
Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Since READONLY state was introduced, ingester would be put back on ACTIVE state after restart. Because the state is hard coded in lifecycler. This PR would preserve ring state in token file right before shutting down and during initialization of lifecycler, state would be restored by reading previous state from token file.
Which issue(s) this PR fixes:
NA
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]